OverlordsIII / VillagerNames

A mod that adds names to villagers and golems
https://www.curseforge.com/minecraft/mc-mods/villager-names-for-fabric/
Creative Commons Zero v1.0 Universal
8 stars 7 forks source link

Cannot properly set Golem names in config #30

Closed mbrozzo closed 2 years ago

mbrozzo commented 2 years ago

I have created a custom list of names for villagers as well as golems. The villager config works fine, but in-game, the golem names list includes the default names on top of the ones I put in the config file. The config file only contains my custom names.

My golemNames.json:

{
  "golemNames": [
    "Robottino",
    "Automa",
    "Golem Ingranaggio Antico",
    "Robo-ceppo",
    "Burattino di Ferro",
    "Gesù 3",
    "Terachad",
    "Emiglio è Meglio"
  ]
}

In-game: image

OverlordsIII commented 2 years ago

Sorry about this, it was a legacy piece of code to make sure users were up to date with their golem names. This will be fixed soon in the coming days

mbrozzo commented 2 years ago

Thank you!

OverlordsIII commented 2 years ago

This should be fixed, would you try seeing if the latest version of the mod fixes this issue? Should be version 3.0.0

mbrozzo commented 2 years ago

Thanks, I will try it and I will let you know!

mbrozzo commented 2 years ago

I tried version 3.0.0 on a clean install (with just dependencies and Mod Menu) and golem names seem to be working as expected, both in the config menu, both in-game. Piglin names look like this instead (I had no config file for piglins, so an empty one was generated), is it normal? image

Another thing, I could not find the file for version 3.0.0 on CurseForge. I was able to download it only by updating the 2.0.2 file using GDLaucher, which in turn only shows version 3.0.0 for Minecraft 1.18.1. Is it just the CurseForge website which has not updated or is something going on?

OverlordsIII commented 2 years ago

We've found a major bug in version 3.0, so it has been archived. The piglin names looking like that is also very confusing, as it should look like the enchanting table text. Will be doing some more testing and debugging

OverlordsIII commented 2 years ago

The pillagers should be fixed now in this version, could you check to see if it works on your side?

mbrozzo commented 2 years ago

Sure thing

mbrozzo commented 2 years ago

Wait, you meant piglins, right? In that case they seem to work as intended.

image

OverlordsIII commented 2 years ago

My bad I get pillagers and piglins confused, but yes thats how they should look. Thanks for letting me know about this issue!

mbrozzo commented 2 years ago

Thank you for the quick fix!