OverlordsIII / VillagerNames

A mod that adds names to villagers and golems
https://www.curseforge.com/minecraft/mc-mods/villager-names-for-fabric/
Creative Commons Zero v1.0 Universal
8 stars 8 forks source link

[Bug] Compatibility Villager Names - Carpet 1.19.2 #52

Closed SylisMC closed 1 year ago

SylisMC commented 1 year ago

Minecraft 1.19.2

Crash on boot (no main menu) 1.19.2

fabric-carpet-1.19.2-1.4.84+v221018.jar villagernames-1.19.2-4.0.8.jar

Villager Names Github Issue Carpet Githup Issue

2023-01-01-1.log.gz

OverlordsIII commented 1 year ago

This was fixed recently. Please update to the latest version of the mod (4.4.0), found here

SylisMC commented 1 year ago

That jar is for 1.19.3, And crashes a 1.19.2 client, the game version is listed in the jar names, sorry I should of made that more clear latest.log

OverlordsIII commented 1 year ago

Here's a 1.19.2 version.

jiriks74 commented 1 year ago

Cannot confirm that it's working with 4.5.0:

Error from console ```java [00:17:21] [main/INFO]: Mixing server.MixinPlayer from nochatreports.mixins.json into net.minecraft.class_1657 [00:17:21] [main/WARN]: @Redirect conflict. Skipping villagernames.mixins.json:LivingEntityMixin from mod villagernames->@Redirect::turnOfConsole(Lnet/minecraft/class_1309;)Z with priority 1000, already redirected by carpet.mixins.json:LivingEntity_cleanLogsMixin from mod carpet->@Redirect::shouldLogDeaths(Lnet/minecraft/class_1309;)Z with priority 1000 [00:17:21] [main/ERROR]: Failed to start the minecraft server java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1309 failed at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.17.jar:?] at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:?] at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?] at java.lang.ClassLoader.defineClass(Unknown Source) ~[?:?] at java.security.SecureClassLoader.defineClass(Unknown Source) ~[?:?] at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.defineClassFwd(KnotClassLoader.java:153) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:355) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.17.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.17.jar:?] at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:?] at net.minecraft.class_6396.handler ```
OverlordsIII commented 1 year ago

Try with this new version (4.5.1): https://www.curseforge.com/minecraft/mc-mods/villager-names-fabric/files/4426546

jiriks74 commented 1 year ago

Starts up for me! Villagers look ok and Carpet with EssentialAddons seem to be working!

OverlordsIII commented 1 year ago

Great! Thanks for reporting.