search

OvermindDL1 / ex_spirit

27 stars 1 forks source link

Fixes serious bug with the symbols parser (plus some docs) #7

Closed tmbb closed 7 years ago

tmbb commented 7 years ago

I'm sorry this PR comes together with the docs for the Context module, but my Git-fu is not enough to change history and turn these two commits into two branches or something like that.

OvermindDL1 commented 7 years ago

I'm sorry this PR comes together with the docs for the Context module, but my Git-fu is not enough to change history and turn these two commits into two branches or something like that.

Nah all good, the commits are distinct and that is the important part. :-)

But yeah, this whole nil branch is a large set of wtf's on my part, thanks for the catch!!!

tmbb commented 7 years ago

But yeah, this whole nil branch is a large set of wtf's on my part, thanks for the catch!!!

I thought so... I was just trying to touch as few lines as possible :p

tmbb commented 7 years ago

Fixed.

tmbb commented 7 years ago

You should bump the version number, release a new version and anounce it in the forum topic. The bug is quite serious :)

OvermindDL1 commented 7 years ago

Woot! Looks great!

You should bump the version number, release a new version and anounce it in the forum topic. The bug is quite serious :)

Yep yep, doing so now. ^.^

Thanks much!!!!