Closed marcelotto closed 3 years ago
Greets, sorry for the delay, I often don't have a GUI much anymore to check websites like this with (I checked this due to your email, thanks for that!)... ^.^;
I need to find a good github cli sometime that can give me push notifications from it...
Taking the first one could work if the result is sorted first (lib
sorts before rel
after all) since the OS can theoretically return any order from the glob, and then take the first if multiple, this is an easy update to your PR, I'll do it now and post another message here after a quick test on that too. :-)
But yep, otherwise a great PR! :-)
Hold on while I make that change and test....
Looks good on my simple test, merging and publishing with a version bump, few minutes...
Published 0.4.4. Please test locally? :-)
I've tested it locally and everything seems to work fine. Thanks.
Here's my naive shoot to fix #59 .
First, I noticed that the files in
rel/
are much smaller, so I assumed that these are stripped down versions of the ones inlib/
for the release without debug info etc. Although I couldn't find any definitive answer, the beam_lib module IMO strongly bakes my assumption that these are produced from the former. So, if my assumption is correct it should be sufficient to take just the first element with the beam file inlib/
.I've tried this version and everything seems to work fine. The protocol dispatching can be applied successfully in the release.