Closed Bonkles closed 2 months ago
Using jake's magical overturemaps-py downloader I was able to quickly inspect this division in the geoparquet.
overturemaps download -o ghent_divisions.geojson -f geojson -t division_area --bbox 50.978137,3.632738,51.074877,3.881304
The resultant geojson does show the same source block repeated over & over:
"sources": [
{
"property": "",
"dataset": "OpenStreetMap",
"record_id": "R571178",
"confidence": null
},
{
"property": "/properties/names/common/bs",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/ca",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/el",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/et",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/fi",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/he",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/id",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/lv",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/pt-BR",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/pt-PT",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/sl",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/sr-Latn",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/th",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
},
{
"property": "/properties/names/common/vi",
"dataset": "Esri Community Maps",
"record_id": null,
"confidence": null
}
],
But it looks like there is more data here, according to language/locale. Seems like the tile generation should omit repeated entries, or at least comma-delimit them so they are not run-on.
I believe the value in the tiles is passed correctly from the GeoParquet, there's just a different source for every name tag, so I think we need the UI to display a list of sources, preferably with rich links to OSM if source=osm, like in #104
Confirmed that @hlfan's fix works, same division now shows up in the inspector as:
Fix has been shipped to the site!
Description
If you go to zoom 12 over Ghent (our default starting area) and click on a division, the source has "OpenStreetMap" and then "Esri Community Maps" is repeated a bunch.
What browser are you seeing the problem on? What version are you running?
Chrome v125
The OS you're using
MacOS 14.5
Steps to reproduce
Navigate to 12.2/51.05061/3.7308 and click on the pink division area that's covering everything. Check out the 'source' info in the inspector panel.
GERS ID of the entity in question (if applicable)
0852785d3fffffff01e15b2df37ade4b
The browser URL at the time you encountered the bug
https://explore.overturemaps.org/#12.2/51.05061/3.7308