Theme selector restyle - Githubissues

OvertureMaps / io-site

MIT License

31 stars 4 forks source link

Theme selector restyle #120

Closed Bonkles closed 1 month ago

Bonkles commented 1 month ago

This PR begins to address #108 with a number of styling updates to the theme/type selector.

UPDATE: After PR Feedback from Ethan and Charlie I've adjusted the styling a bit. Great comments and I think it's an improvement.

Here is a before/after pic:

Dark Mode:

Light Mode:

charliemcgrady commented 1 month ago

Overall a great update! A couple of nits:

The alternating colors is great. There should either be padding to the left of the checkboxes or the div should go all the way to the div. If we do the former, might want to add a border-radius as well. Also consider adding more padding to the bottom.
I personally would prefer a lighter grey for the light mode alternative background grey.
Update the control itself to also be inverted when dark mode is enabled.

Bonkles commented 1 month ago

@charliemcgrady great feedback, I've updated the margins, padding, and overall flow by adding a subtle border and ensuring that the odd/even background styling goes the full width of the container: