OvertureMaps / io-site

MIT License
33 stars 5 forks source link

Site needs support for the new Addresses theme #95

Closed Bonkles closed 2 months ago

Bonkles commented 3 months ago

Description

There's a new theme we should be visualizing- addresses. There's a temporary URL that we can use for just getting the data up onto the site that @bdon provided:

https://protomaps.dev/~bdon/addresses.pmtiles

Of course this is a temp URL but we can use it for staging purposes / getting something built.

This task ask that we:

What browser are you seeing the problem on? What version are you running?

Chrome v120

The OS you're using

MacOs 14

Steps to reproduce

n/a - just a feature we don't yet support.

GERS ID of the entity in question (if applicable)

n/a

The browser URL at the time you encountered the bug

n/a

eti7075 commented 3 months ago

Screenshot 2024-07-16 at 2 19 57 PM This is the proposed styling for addresses. I used with a basic cyan to clearly be separate from other themes, and reused the point styling used in places for the geometry.

eti7075 commented 3 months ago

Subject to change: Size and color of the dots - where there is address data, there is much more than other themes, so we might want to consider a small point radius to reduce clutter, and the cyan is not set in stone, but currently does a good job of being very different from other theme colorings

bdon commented 3 months ago

We could parameterize ThemeTypeLayer to make the point radius for addresses smaller:

https://github.com/OvertureMaps/io-site/blob/main/site/src/Map.jsx#L84

eti7075 commented 3 months ago

Here is addresses at a radius of 5. I think it is a good balance between being a different size than other points, while still maintaining the definition that we want a point to have at lower zoom values. Screenshot 2024-07-17 at 9 32 32 AM

bdon commented 3 months ago

Looks good to me! I will also prepare a PR to put labels on top, since it looks awkward with points covering labels right now...