search

Overv / MineAssemble

A tiny bootable Minecraft clone written partly in x86 assembly
MIT License
1.04k stars 68 forks source link

Makefile organization #6

Closed duckinator closed 11 years ago

duckinator commented 11 years ago

Make it so most of the things in the Makefile that may change are now stored in variables.

Overv commented 11 years ago

I would accept this immediately, but I'm currently working with someone else on a new version of the Makefile as well (see issue #5).

duckinator commented 11 years ago

It's all good, just threw it together real quick because I already had the Makefile open. Very awesome project, btw. :D

rikusalminen commented 11 years ago

I did similar refactoring to the Makefile in the issue #5 pull request. The differences: I didn't use override for CFLAGS and I used $(wildcard src/*.c) to scan for source files. In addition, I did a bunch of other changes too to build debuggable elf files.

@duckinator It is not a good idea to use AS and ASFLAGS with NASM sources, they will collide with the implicit Make rules used to build GNU assembler code (.s and .S files).

@Overv I think you should merge #5, close this pull req and later add override to CFLAGS, etc if it makes sense to allow overriding the compiler flags in the make command line. Does this sound ok to you?

Overv commented 11 years ago

As @rikusalminen said, override will be added to the new makefile from #5.