Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.08k stars 513 forks source link

Tutorial example make file has an error #196

Closed Taracandra closed 3 years ago

Taracandra commented 3 years ago

LDFLAGS = -L$(VULKAN_SDK_PATH)/lib 'pkg-config --static --libs glfw3' -lvulkan should be : LDFLAGS = -L$(VULKAN_SDK_PATH)/lib `pkg-config --static --libs glfw3` -lvulkan so ' is not ` and unfortunately this throws an error. Using Ubuntu20.4

Overv commented 3 years ago

Where did you see the version with wrong quotes?

lewa-j commented 3 years ago

here https://github.com/Overv/VulkanTutorial/blob/master/en/02_Development_environment.md#L374

Taracandra commented 3 years ago

I must have typed that part and thought, like usual, that it was a copy-paste action.

This make file example looks ok, so the error was from me, and great apologies for the inconvenience.


VULKAN_SDK_PATH = /home/user/VulkanSDK/x.x.x.x/x86_64

CFLAGS = -std=c++17 -I$(VULKAN_SDK_PATH)/include LDFLAGS = -L$(VULKAN_SDK_PATH)/lib pkg-config --static --libs glfw3 -lvulkan

VulkanTest: main.cpp g++ $(CFLAGS) -o VulkanTest main.cpp $(LDFLAGS)

.PHONY: test clean

test: VulkanTest LD_LIBRARY_PATH=$(VULKAN_SDK_PATH)/lib VK_LAYER_PATH=$(VULKAN_SDK_PATH)/etc/vulkan/explicit_layer.d ./VulkanTest

clean: rm -f VulkanTest

On Sun, Aug 2, 2020 at 9:40 PM Alexey notifications@github.com wrote:

here https://github.com/Overv/VulkanTutorial/blob/master/en/02_Development_environment.md#L374

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Overv/VulkanTutorial/issues/196#issuecomment-667691238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6Y6ODZSFM5JBKDN4WONTLR6WD5LANCNFSM4PLOMVRQ .