search

Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.15k stars 516 forks source link

Recompiling With /std:c++latest in Visual Studio Breaks The Project #231

Closed trutty2 closed 3 years ago

trutty2 commented 3 years ago

CookbookSampleFramework.h / OS.cpp cannot be recompiled in a project with C++20 features enabled in Visual Studio (it seems to work fine as long as changes aren't made to these files). I have limited experience in C++ (and none in template metaprogramming) as of right now, but from what I gather it's because of the VkDestroyer template code relying on some features that are removed from the language past C++17.

Here's the error message:

Error C2664 'VulkanCookbook::FrameResources::FrameResources(VkCommandBuffer &,VulkanCookbook::VkDestroyer &,VulkanCookbook::VkDestroyer &,VulkanCookbook::VkDestroyer &,VulkanCookbook::VkDestroyer &,VulkanCookbook::VkDestroyer &)': cannot convert argument 2 from '_Ty' to 'VulkanCookbook::VkDestroyer &'

trutty2 commented 3 years ago

Whopsie, submitted this to the wrong repository.