Edit tutorial to reset & record command buffers each frame

[charles-lunarg]

This is a large change to the tutorial which makes the tutorial re-record command buffers. Originally described in #202 (and this PR fixes #202 )

Changes:

• Modify the function that records into the command buffer so that it accepts a command buffer and image index.
• Split "Rendering and Presentation" into 2 chapters, one that introduces fences, semaphores, the main rendering functions (acquire/submit/present). Second chapter is dedicated to introducing multiple frames in flight.
• Rewrite the introduction of fences and semaphores.
• Made buffers, descriptors, and command buffers have MAX_IMAGE_IN_FLIGHT duplication, not swapchain image count.
• Remove command buffer, descriptor set, and VkBuffer recreation from swapchain resizing
• Remove imagesInFlight, since it is no longer necessary.

[Overv]

Very nice! I'll be able to start reviewing this PR sometime this week.

[charles-lunarg]

It has come to my attention that there may be a sync bug W.R.T the depth buffer. Gist is that the same depth buffer could be read/written to by multiple frames in flight. A much more detailed description & solution is presented in the vk-guide.dev repo. https://github.com/vblanco20-1/vulkan-guide/pull/53

[ralphtheninja]

@charles-lunarg Thanks for taking your time with this. I'm a beginner myself and I was pondering these exact concepts the other day.

[ralphtheninja]

Nice review!

[Overv]

@Krenodeno Would you be interested in incorporating these changes in the French translation as well? Otherwise we'll have to add a disclaimer that some parts of the translation are out of date.

[Krenodeno]

Sure, I'll do it. Not sure how much time it will take though, I'll do my best :)

[charles-lunarg]

I addressed all the changes requested by Overv, cleaning up some paragraphs, and fixing resizing to not deadlock.

These include:

• Adding more information about fence and semaphore resetting
• Adding a paragraph explaining the choice of 2 for MAX_FRAMES_IN_FLIGHT
• Using uint32_t for currentFrame instead of size_t
• Moving resetting the fence to after acquiring a swapchain image
• Uncommenting some accidentally commented code.

[Krenodeno]

@Overv How can I edit the translation ? Forking the fork will not display change here (or does it ?), or Charles will have to merge to be displayed here.

[Overv]

@Overv How can I edit the translation ? Forking the fork will not display change here (or does it ?), or Charles will have to merge to be displayed here.

There are still going to be a few changes to this PR (possibly somewhat significant), so I'd wait a bit with the translation work. I think that once this PR is finished it would be good to get the changes in the English version out as quickly as possible and then you can work on the translation in your own pull request just like with earlier changes.

[Krenodeno]

There are still going to be a few changes to this PR (possibly somewhat significant), so I'd wait a bit with the translation work. I think that once this PR is finished it would be good to get the changes in the English version out as quickly as possible and then you can work on the translation in your own pull request just like with earlier changes.

Okay, that's good for me !

[charles-lunarg]

FYI There is nothing more to do in this PR as far as I can tell. I don't have any outstanding questions or concerns. Totally capable of doing further revisions if someone else wants to review.

[SaschaWillems]

Totally happy with these changes. They make the tutorial as a whole much better. Would love to se this merged and the website updated :)

[Overv]

Excellent work!

[ralphtheninja]

@Overv Is this automatically deployed to the live tutorial?

[Overv]

@ralphtheninja Yeah, the website is automatically redeployed once a day.

[Overv]

@Krenodeno Would you have time to work on the translation soon? :)

[Krenodeno]

I'll try to look at it this week. I think there are other changes made by other PRs that I'll have to update as well.