Closed zixin96 closed 2 years ago
Hello, I've found some inconsistencies between the text and the source code in the index buffer section.
Using an index buffer for drawing involves two changes to createCommandBuffers.
In the source code, we made changes to recordCommandBuffer instead of createCommandBuffers.
recordCommandBuffer
createCommandBuffers
The text shows
vkCmdBindVertexBuffers(commandBuffers[i], 0, 1, vertexBuffers, offsets); vkCmdBindIndexBuffer(commandBuffers[i], indexBuffer, 0, VK_INDEX_TYPE_UINT16); vkCmdDrawIndexed(commandBuffers[i], static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);
, but the source code shows:
vkCmdBindVertexBuffers(commandBuffer, 0, 1, vertexBuffers, offsets); vkCmdBindIndexBuffer(commandBuffer, indexBuffer, 0, VK_INDEX_TYPE_UINT16); vkCmdDrawIndexed(commandBuffer, static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);
Thanks, Zixin
Thanks for reporting. I've fixed this and a bunch of other inconsistencies.
Hello, I've found some inconsistencies between the text and the source code in the index buffer section.
In the source code, we made changes to
recordCommandBuffer
instead ofcreateCommandBuffers
.The text shows
, but the source code shows:
Thanks, Zixin