Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.06k stars 511 forks source link

The Chinese translation is complete. Request a review. #307

Open huzhenbang opened 1 year ago

huzhenbang commented 1 year ago

The Chinese translation is complete. Request a review.

Overv commented 1 year ago

Any native speakers who can pitch in to review this? @chirsz-ever @fangcun010

chirsz-ever commented 1 year ago

翻译应该放在 zh 文件夹并中并在 config.json 中加入中文配置,参见 https://github.com/chirsz-ever/VulkanTutorial/commit/6802acba9711c2a574d66c6966e43436956c8c9f

chirsz-ever commented 1 year ago

build_ebook.py 换行符变成了 CRLF,应该维持原样使用 LF。

如果是在 Windows 上进行开发可以将 git 配置为提交时使用 LF,checkout 到文件系统中时使用 CRLF^git-autocrlf

git config --global core.autocrlf true

配置后建议使用 git add --renormalize . 清理工作区。

chirsz-ever commented 1 year ago

duax.io 处理中文 URL 有问题,文件名应当改用英文,并在文件开头使用元数据块来指明中文标题

中文路径问题将在 https://github.com/Overv/daux.io/pull/2 被合入后解决。

chirsz-ever commented 1 year ago

发现的一些问题:

排版相关可以参考 中文排版指北

图形学术语可以参考《游戏引擎架构》中英词汇索引表

参考 这里 的建议,某些术语可以保留英文原文,如使用“uniform buffer”或“uniform 缓冲”而非“统一缓冲区”,“统一的缓冲区”。

orbitgw commented 1 year ago

When will the translation be deployed? @Overv

Overv commented 1 year ago

@orbitgw Would you be willing to go through the chapters and review them? If a native speaker can confirm that it looks good then this can be deployed.

orbitgw commented 1 year ago

@Overv I would be happy to do it, but it will take time. Cause I am currently a high school student and am about to face the college entrance examination. I need to put more energy into my studies. I will graduate in June 2024, and by then, I will have plenty of time to do this work.

Overv commented 1 year ago

@orbitgw That is fine. Perhaps someone else has a chance to look at it earlier.

chirsz-ever commented 1 year ago

This PR is a mess with unrelatied modifications and wrong format. The author did not take action or reply to comments for half a year. I think I could start a new translation PR in some days.

@Overv How do you think about https://github.com/Overv/daux.io/pull/2? If you think it change too much, It's OK to just add https://github.com/Overv/daux.io/commit/b3ab5c3a79e0e69a4685e79c6da14d5bc2ac0399 to remove hard-coded "Introduction" path, and I will use English file names in the Chinese translation.

orbitgw commented 1 year ago

@chirsz-ever

This PR is a mess with unrelatied modifications and wrong format. The author did not take action or reply to comments for half a year. I think I could start a new translation PR in some days.

@Overv How do you think about Overv/daux.io#2? If you think it change too much, It's OK to just add Overv/daux.io@b3ab5c3 to remove hard-coded "Introduction" path, and I will use English file names in the Chinese translation.

我赞同你的想法,用中文做路径太奇怪了,而且不好访问

orbitgw commented 1 year ago

@Overv I have roughly browsed through it and there is a suspicion that this PR may have completely used translation software without manual verification.

orbitgw commented 1 year ago

@chirsz-ever 我想咱们可以合作一下

Overv commented 1 year ago

我同意,用英文保留文件名会更方便,这样它们就更容易与其他版本匹配了

翻译准备好发布时,我会修复介绍路径