Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.15k stars 515 forks source link

Added: build_ebook_v2.py #326

Closed H-G-Hristov closed 1 year ago

H-G-Hristov commented 1 year ago

Notes: The new script is based on the old one. It uses the same RegEx'es unchanged. It's a bit verbose to make it more clear what's going on.

(I used the email of my other account so I didn't expect that GitHub will link the commits in such way.)

Overv commented 1 year ago

Thank you for your PR. Could you change the PR to overwrite the original script rather than adding a new file? That would make it more clear that it is intended to be replaced. Also, could you generate the French documents and add them to the PR as well?

H-G-Hristov commented 1 year ago

@Overv Thank you for the remarks.

  1. Fixed the title page/meta data
  2. Replaced the old script
  3. Generated new ebooks for English and French
Overv commented 1 year ago

I'm sorry for not having gotten back to you yet. I'll try to review this as soon as possible, which will probably be tomorrow.

Overv commented 1 year ago

I refactored the script to be more maintainable and fit my own preferred code style better, and merged it. Thank you for your contribution.