search

Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.06k stars 511 forks source link

Fix indentation of `memcpy()` lines #346

Closed Calinou closed 8 months ago

Calinou commented 11 months ago

These lines weren't aligned with the rest of the code.

Edit: This actually appears to be intentional: https://github.com/Overv/VulkanTutorial/pull/175 I'd suggest wrapping it within a { ... } block in this case, so that indentation is preserved by tools like clang-format (which I always use in my own projects :slightly_smiling_face:).

Overv commented 11 months ago

While I could add the {...} I feel like it would make the code a bit too verbose. I think that if people use an autoformatter anyway, it's better to just remove the indentation in these particular cases.

Calinou commented 9 months ago

Bump :slightly_smiling_face: What should we do about this PR?

Overv commented 8 months ago

I'd say the code should be left as is for now.