Overv / VulkanTutorial

Tutorial for the Vulkan graphics and compute API
https://vulkan-tutorial.com
Creative Commons Attribution Share Alike 4.0 International
3.2k stars 527 forks source link

Suggestions about misleading terminologies in "Descriptor layout and buffer" chapater #357

Closed chuigda closed 1 year ago

chuigda commented 1 year ago

According to the Vulkan specification, there's actually no terminology descriptor layout, only descriptor set -- an opaque object containing storage for a set of descriptors, and descriptor set layout -- defines the types and numbers of descriptors of a descriptor set. And in the tutorial, according to my understand, descriptor layout simply means descriptor set layout. But using another name might mislead beginners (me, for example), as they might think that descriptor layout and descriptor set layout are two different things at initial. Changing to descriptor set layout should be an applicable solution.

chuigda commented 1 year ago

Also, according to the Vulkan specification and the OpenGL wiki, buffer object generally denotes some kind of handle referring to certain graphics API relevant, GPU-accessible resources. Thus calling a struct in CPU memory UniformBufferObject might be somewhat confusing. Maybe it's better to use some name like UniformData, meaning that this is some data prepared and to be uploaded to buffer objects. I could also make changes in #358 if desired.