search

Overv / WebCraft

Minecraft clone written in Javascript.
zlib License
386 stars 179 forks source link

hello, I made a sight.js to hide the cursor, to make it more looks like miecraft #36

Open Jim-JZ-Chen opened 6 years ago

Jim-JZ-Chen commented 6 years ago

hello, I made a sight.js to hide the cursor, to make it more looks like miecraft

Overv commented 6 years ago

Could you elaborate on your pull request? That's a lot of code changes to just hide the cursor.

warengonzaga commented 6 years ago

@dfjhde please add comments on your code... it is hard to know if it is required to change or not.

Jim-JZ-Chen commented 6 years ago

@WarenGonzaga i just added more comments on my code, please tell me specifically if you have problem on my code, thank you!

warengonzaga commented 6 years ago

@Jim-JZ-Chen okay got it... will review it...

warengonzaga commented 6 years ago

@Jim-JZ-Chen there is an issue when moving the mouse in smaller screen... the most are not able to move when it is on a small screen. Please fix it... I don't understand if the full screen is necessary.

SmilerRyan commented 5 years ago

The script works good, however I cannot seem to select different blocks while using this. I think you should add a way to toggle it with a key, or disable looking while a key is being held.