search

OvidijusParsiunas / myvision

Computer vision based ML training data generation tool :rocket:
https://myvision.ai
GNU General Public License v3.0
585 stars 66 forks source link

Horizontal scrolling via mouse wheel fix #37

Closed davitv closed 2 years ago

davitv commented 2 years ago

Not sure if it is a bug or intended, but found out that horizontal scroll doesn't work because of possible typo.

BTW love the application, thank you so much!

OvidijusParsiunas commented 2 years ago

Hey @davitv, thankyou so much for creating this PR. Before approving it, I need to take time to make sure that the new change does not impact any of the current functionality and is in-fact an enhancement. I am currently neck deep in my normal day-work and I'm trying to finish off some other opensource projects that I'm currently working on, so it may take a little bit of time before I can look at it in detail (no more than 1-2 weeks). I just wanted to give you a heads up that I have definitely seen your PR and I am very keen to get it merged as soon as possible. As soon as I get a chance, I'll evaluate and take action on your PR!

Thankyou once again! (Also, if you have a chance, would you mind testing the horizontal scroll and seeing if it works correctly when zoomed in with shapes etc, that would save me a lot of time time and would be much appreciated!!)

davitv commented 2 years ago

Hi @OvidijusParsiunas ! Thank you for the response, no worries at all about timing. Really appreciate your efforts, hope you have blasting weeks! Regarding testing with zoom in/out with horizontal scroll — so far i have tested it a lot with Chrome browser, and looks good, nothing seems to be broken, but not sure yet about Firefox, but i will have to test it too this week and will let you know. Please, feel free to tell if anything else i can help with and i will try to on my free time. Thank you!

OvidijusParsiunas commented 2 years ago

I tested the PR out and it does indeed facilitate horizontal scrolling when zoomed in. Thankyou very much for your contribution! :rocket: