feat: Allow users to change the port by setting environment variables

OwO-Network / DeepLX

Powerful Free DeepL API, No Token Required

https://ssa.sx/deeplx

MIT License

6.64k stars 532 forks source link

feat: Allow users to change the port by setting environment variables #23

Closed cijiugechu closed 1 year ago

missuo commented 1 year ago

I'm sorry, using the env method to set environment variables is not a good choice for this program in my opinion. I think it is a better choice to use the command line to pass arguments and default to 1188 when the user does not pass any arguments. e.g. deeplx -p 8080

missuo commented 1 year ago

Hi, first of all thank you for the PR, it helped me to refine quite a few things I wanted to do. Unfortunately, when I was trying to release 0.7.5, I noticed that with the latest version, it didn't start properly using brew services. So to make it easier for users, I recovered the main branch to 0.7.4 and your PR for the specified port stayed in the dev branch and I will merge to main only after I figure out the problem.