I completed The Corsair Curse, and the plugin was flawless. It has quite a diverse bit of steps, and quite a few of them. Npc's and Obj's etc. were all highlighted really well, no ghost overlays. I'm confident it's working how it should now.
Those of you who review the code might think the locations I used to place the subscribes is very weird. I hated doing it, but due to the way the different classes are modularized, and instantiating the class BEFORE member injection. It can't be placed in the constructors like I had wanted to.
This fully fixes questhelper based on my testing.
I completed The Corsair Curse, and the plugin was flawless. It has quite a diverse bit of steps, and quite a few of them. Npc's and Obj's etc. were all highlighted really well, no ghost overlays. I'm confident it's working how it should now.
Those of you who review the code might think the locations I used to place the subscribes is very weird. I hated doing it, but due to the way the different classes are modularized, and instantiating the class BEFORE member injection. It can't be placed in the constructors like I had wanted to.
See: https://github.com/Owain94/OpenOSRS-RL-hub/blob/e1f68a384c137865384aeda5acdd9adaa96dc16a/questhelper/src/main/java/com/questhelper/QuestHelperPlugin.java#L559
is called before
https://github.com/Owain94/OpenOSRS-RL-hub/blob/e1f68a384c137865384aeda5acdd9adaa96dc16a/questhelper/src/main/java/com/questhelper/QuestHelperPlugin.java#L575