Owl-Maintain / brlaser

open-source CUPS driver for monochrome Brother laser printers
GNU General Public License v2.0
27 stars 8 forks source link

Add hl-5370dw support #8

Closed erooke closed 10 months ago

erooke commented 10 months ago

Printer Entry:

Device: uri = usb://Brother/HL-5370DW%20series?serial=C2J486800
        class = direct
        info = Brother HL-5370DW series
        make-and-model = Brother HL-5370DW series
        device-id = MFG:Brother;CMD:PJL,PCL,PCLXL;MDL:HL-5370DW series;CLS:PRINTER;
        location =

Verified:

Additional notes: Contrary to the other printers the duplex directive had to be set to normal to get correct duplex printing to work.

QORTEC commented 10 months ago

Thank you for the pull request, the PCFileName will need to be updated, otherwise everything looks good.

Contrary to the other printers the duplex directive had to be set to normal to get correct duplex printing to work.

I plan to create a wiki, and would like to provide a note about this behaviour. If you could you provide more details that would be helpful?

erooke commented 10 months ago

Thank you for the pull request, the PCFileName will need to be updated, otherwise everything looks good.

What should the PCFileName be? I'm assuming it should include the d for duplex but omit the w for wireless? Another thing to potentially add to this future wiki I suppose.

I plan to create a wiki, and would like to provide a note about this behaviour. If you could you provide more details that would be helpful?

With duplex: rotated my printer could only flip along the short side. I followed this: https://www.cups.org/doc/ref-ppdcfile.html#Duplex to figure out the acceptable values.

QORTEC commented 10 months ago

I'm assuming it should include the d for duplex but omit the w for wireless? Another thing to potentially add to this future wiki I suppose.

Correct, I made a note in commit 8458dbc3146521b420596cfd103e184487270217. It will definitely need to be added to the future wiki.

Thanks for adding another printer!