search

OwlCarousel2 / OwlCarousel2

DEPRECATED jQuery Responsive Carousel.
http://owlcarousel2.github.io/OwlCarousel2/
Other
7.89k stars 2.28k forks source link

Lightbox #187

Open doshea opened 10 years ago

doshea commented 10 years ago

Pretty self-explanatory: I'd love to see an optional lightbox integrated for images on the carousel like AmazingSlider (http://amazingslider.com/) has. Theirs takes forever to open though, so something like Magnific Popup (http://dimsemenov.com/plugins/magnific-popup/) would be probably be better.

I realize this would entail quite a bit of work -- just figured I'd post it.

witrin commented 10 years ago

I already implemented such a feature for myself by using Twitter Bootstrap and this slider. The thing is, but this is just my personal opinion, to make such a feature for every imaginable case right would be fill a hole project like this. So maybe someone is willing to start something like this by using a good modal technique and this slider in separate project first ...

NunoBentes commented 10 years ago

I agree!!! And you should not have any problems to implement a Lightbox by yourself! IMO you should not "comprise" this amazing carousel to by implementing other plugins integration.

dude2511 commented 9 years ago

Has it been easy to integrate Bootstrap's modal with this slider?

witrin commented 9 years ago

I've done it. Was not so hard.

dude2511 commented 9 years ago

Somehow it's not working right the way I tried it. Could you give me some pointers in the right direction?

witrin commented 9 years ago

Make a nice JS Bin! Use therefore the template from the README; thus you use always the latest develop. Post this in a new issue. But remember isolate your demo, the less is more! I'll try to help then.

jpcharrier commented 9 years ago

Hey just to add my 2c in on this... We have been LOVING this slider... and we use it alot. But one thing our clients repeatedly ask for is a lightbox. We have implemented both twitter bootstrap models, magnific pop up, and fancybox... Sure, we could keep doing this... and We can make it work. But thats beside the point... Having an API in a slider that does both would be far more convenient. (we continually search for this weekly...)

Given that Owl is already modular, I dont see how incorporating another build-in plugin as a lightbox would be considered a comprimise at all, but an excellent addition to an already awesome package. There isnt a slider that I'm aware of that is as flexible and option rich as Owl. It would be amazing to see this carried on to incorporating a lightbox option also. Hopefully we see this come to be.

As i mentioned above we are constantly on the lookout for a package containing both, I know a lot of developers around our area (New Zealand) and developers I work with in the US do the same.. Heres hoping Owl does it before someone else does... :)

witrin commented 9 years ago

I would make it in a separate project because the plugin would be too big for this.

formariz commented 9 years ago

Guys, I need use Magnific Popup in my project. Anyone done this?