https://mykhailodanilenko.github.io/web-client/
this pull request adds live fetching from api sources selected in settings. I was able to preserve the base videos API, however we will have to part ways with the Video Service and its context. I also set up tests for components so now we can test component behavior as well. the ability to use test json data is also preserved, however it is not feasible to fetch thumbnails from remote sources for local test jsons since we are now using video uuids instead of object ids.
๐ Motivation and Context
57 #33 #37 #7
๐งช How Has This Been Tested?
data fetching should work across browsers and platforms, however the cors errors are very dynamic at the moment.
๐ฆ Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
โ Checklist (copied from README)
[ ] Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
[x] Reference the GitHub issue that you are contributing on in your commit title or body
[x] Sign your commits, as this is required by the automated GitHub PR checks
[x] Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
[x] Include links and illustrations in your pull request to make it easy to review
[x] Request a review by @ar9708, @OGTor, @tryklick and @mblomdahl
๐ Description
https://mykhailodanilenko.github.io/web-client/ this pull request adds live fetching from api sources selected in settings. I was able to preserve the base videos API, however we will have to part ways with the Video Service and its context. I also set up tests for components so now we can test component behavior as well. the ability to use test json data is also preserved, however it is not feasible to fetch thumbnails from remote sources for local test jsons since we are now using video uuids instead of object ids.
๐ Motivation and Context
57 #33 #37 #7
๐งช How Has This Been Tested?
data fetching should work across browsers and platforms, however the cors errors are very dynamic at the moment.
๐ฆ Types of changes
โ Checklist (copied from README)
npx eslint .
andnpx prettier --check ../
from the./OwnTube.tv/
directory (without errors/warnings)