This PR introduces working with instance as a url parameter. Currently, the structure is like this:
[baseURL]/[instance]/video?id=[video uuid]/
Unfortunately, the whole functionality won't work on GitHub pages deployment anyhow, either if we choose static or SPA export output. read more. As a hacky fallback, we can pre-render all video pages for all listed instances, but it's questionable if it is strictly necessary.
๐ Motivation and Context
67
๐งช How Has This Been Tested?
on web - desktop + mobile, on Expo Go - ios & android, didn't test deeplinking as we haven't configured any mobile platforms yet
๐ฆ Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
โ Checklist (copied from README)
[x] Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
[x] Reference the GitHub issue that you are contributing on in your commit title or body
[x] Sign your commits, as this is required by the automated GitHub PR checks
[x] Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
[x] Include links and illustrations in your pull request to make it easy to review
[x] Request a review by @ar9708, @OGTor, @tryklick and @mblomdahl
๐ Description
This PR introduces working with instance as a url parameter. Currently, the structure is like this:
[baseURL]/[instance]/video?id=[video uuid]/
Unfortunately, the whole functionality won't work on GitHub pages deployment anyhow, either if we choose static or SPA export output. read more. As a hacky fallback, we can pre-render all video pages for all listed instances, but it's questionable if it is strictly necessary.๐ Motivation and Context
67
๐งช How Has This Been Tested?
on web - desktop + mobile, on Expo Go - ios & android, didn't test deeplinking as we haven't configured any mobile platforms yet
๐ฆ Types of changes
โ Checklist (copied from README)
npx eslint .
andnpx prettier --check ../
from the./OwnTube.tv/
directory (without errors/warnings)