OwnTube-tv / web-client

Portable video client for PeerTube in React Native
https://owntube-tv.github.io/web-client/
The Unlicense
3 stars 12 forks source link

Save instance in url route #73

Closed mykhailodanilenko closed 3 months ago

mykhailodanilenko commented 3 months ago

๐Ÿš€ Description

This PR introduces working with instance as a url parameter. Currently, the structure is like this: [baseURL]/[instance]/video?id=[video uuid]/ Unfortunately, the whole functionality won't work on GitHub pages deployment anyhow, either if we choose static or SPA export output. read more. As a hacky fallback, we can pre-render all video pages for all listed instances, but it's questionable if it is strictly necessary.

๐Ÿ“„ Motivation and Context

67

๐Ÿงช How Has This Been Tested?

on web - desktop + mobile, on Expo Go - ios & android, didn't test deeplinking as we haven't configured any mobile platforms yet

๐Ÿ“ฆ Types of changes

โœ… Checklist (copied from README)

ar9708 commented 3 months ago

@mykhailodanilenko I see you're still pushing changes here, so I put it in "draft mode". Please mark it as ready-for-review when you're satisfied.

mykhailodanilenko commented 3 months ago

closed in favor of #77