OwnWeb / flutter_map_tappable_polyline

A tappable Polyline plugin for flutter_map
https://pub.dev/packages/flutter_map_tappable_polyline
MIT License
54 stars 45 forks source link

Are there plans to upgrade the dependency on flutter_map to 3.0? #50

Closed MaxiStefan closed 1 year ago

MaxiStefan commented 2 years ago

Hi,

I tried to update the plugin locally to depend on flutter_map 3.0.0 and it seemed to work. However, when there are polygons on the map, the gesture callback on polylines seems to be omitted somehow.... No clue where this fails and I was curious if someone more knowledgeable has looking into it and would help migrating the plugin to 3.0.0

HugoHeneault commented 2 years ago

Hello there,

We're quite busy here, I don't know if @tuarrep has more time than me.

49 could do the job (I haven't tested it), do try it and report any issues and we'll try to follow up :)

Thanks

tuarrep commented 2 years ago

I'll have a look this week

HugoHeneault commented 2 years ago

I'll have a look this week

Awesome! 🙌 Thanks

MaxiStefan commented 2 years ago

Hi @tuarrep,

Any progress on this?

S-Man42 commented 2 years ago

please upgrade the plugin!

HugoHeneault commented 2 years ago

I don't have time to do review this week, sorry :(

In the meantime you can use this branch in your pubspec.

jean-gblr commented 2 years ago

@HugoHeneault Hello do you have time this week then ? :D

sirkalmi commented 1 year ago

Hello, I did it, I'll push it when I get permission.

sirkalmi commented 1 year ago

Available here: https://github.com/sirkalmi/flutter_map_tappable_polyline

jtthrillson commented 1 year ago

The new version of flutter_map (3.1.0) has a breaking change to PolylinePainter. I made quick commit to address that. https://github.com/jtthrillson/flutter_map_tappable_polyline

I've opened a PR with the changes: https://github.com/OwnWeb/flutter_map_tappable_polyline/pull/51

Mike-3 commented 1 year ago

Any progress ?

HugoHeneault commented 1 year ago

Any progress ?

Hello ! Yes, we're working on it.

Sorry for the delay.

S-Man42 commented 1 year ago

There are many PRs to help you upgrading the plugin. Please take care of them an upgrade the package!

Mike-3 commented 1 year ago

When do you think the new version will be operational?

HugoHeneault commented 1 year ago

I've merged #51 and will release a new version really soon.

HugoHeneault commented 1 year ago

Version 4.0.0 released :)