search

OwnWeb / flutter_map_tappable_polyline

A tappable Polyline plugin for flutter_map
https://pub.dev/packages/flutter_map_tappable_polyline
MIT License
54 stars 45 forks source link

FM v6 is coming soon #58

Closed JaffaKetchup closed 1 year ago

JaffaKetchup commented 1 year ago

The next version of flutter_map is coming soon, with breaking changes for all users and plugins!

Expected CHANGELOG: https://github.com/fleaflet/flutter_map/blob/release-prep/CHANGELOG.md Likely to be merged PR with significant impacts: fleaflet/flutter_map#1615 Release prep PR: fleaflet/flutter_map#1632 New documentation (path liable to change): https://docs.fleaflet.dev/v/v6-1 Expected migration instructions, suitable for most users: https://docs.fleaflet.dev/v/v6-1/getting-started/migrating-to-v6 List of commits since v5 (more to come): https://github.com/fleaflet/flutter_map/compare/v5.0.0...master

Mike-3 commented 1 year ago

V6 is released

JaffaKetchup commented 1 year ago

Hey @HugoHeneault (I think you're maintaining this),

We (the FM team) were wondering if you are still planning to maintain this repository? The last commit was a while ago, and we've had a PR submitted to the FM repo to improve some rough edges: see #59 & #56 here, and fleaflet/flutter_map#1685 & fleaflet/flutter_map#1686.

The PR on the FM repo still isn't confirmed or merged yet, as we want to make sure that this repo is actually abandoned before absorbing it. If you (or anyone else) is still planning to maintain this, we'll hold off.

We'd be extremely grateful for a response, and no worries if you're too busy or have just moved on :)

HugoHeneault commented 1 year ago

Hey @JaffaKetchup :)

Thanks for asking, really appreciate it :) I'll do my best to merge it this week.

Quite busy here, still want to maintain the plugin but if things accumulate too much it might be better to merge everything in the main FM repo. I'd say it's also an FM team decision: do you prefer codebase to grow and have have hands on more responsibility but also keep everything synced (better dx for FM users) or let each maintainer/team handle plugins updates?

JaffaKetchup commented 1 year ago

@HugoHeneault Ok, for now, we'll try to keep things here. It's a possibility that this could now be handled by us, but this was made before that was reasonable, and therefore, we don't want to absorb a plugin with a maintainer who's still active!

I've asked @thomascoumau, the author of #56 and fleaflet/flutter_map#1686, to resubmit his PR here (I don't think #56 is quite up to date with all the changes he wants to make), so hopefully that'll work.

HugoHeneault commented 1 year ago

Great! @JaffaKetchup I'm finishing v6 migration, and it seems that TapPosition isn't exported anymore.

I still need it, do I have to craft a PR on FM repo?

JaffaKetchup commented 1 year ago

Hmm, I'll need to track that down and open a PR - I guess I forgot to export it after getting rid of the Plugin API import. I'll have some time in about an hour so I can do it then, or feel free to do it now.

JaffaKetchup commented 1 year ago

Actually @HugoHeneault, something may have just changed, so I'll hold on for a minute.

Do you think you could join the FM Discord and let me know your username?

HugoHeneault commented 1 year ago

I've joined the server and asked you as a friend