PID values not stored via MAVLink

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open APM Planner
2. Action -> PID Config MAVLink
3. Change Servo Pitch P value
4. Write Pids
5. Close PID Config MAVLink
6. Action -> PID Config MAVLink
7. Confirm Servo Pitch P value is the new value
8. Reset APM
9. Action -> PID Config MAVLink
10. Observe that Servo Pitch P value is back to the old value

What version of the product are you using? On what operating system?
Trunk r2284, libraries r1712, APM Planner 0.4.4070.259

Original issue reported on code.google.com by bjpcalt...@gmail.com on 22 Feb 2011 at 9:08

[GoogleCodeExporter]

Thanks for the report Ben,

We have a mixed implementation that is showing up here.  As a big picture 
question is it better to have parameters sent from the GCS immediately saved to 
EEPROM, or only change the current value and then only save the parameters to 
EEPROM if told to do so (as happens in this case).  If the latter, it may be an 
all (parameters) or none thing....

I'd appreciate some feedback on your preference.

Original comment by dewei...@gmail.com on 14 Mar 2011 at 10:08

• Changed state: Accepted

[GoogleCodeExporter]

It feels to me like saving each parameter every time it changes is wasteful, so 
I'd probably be in favor of only writing to EEPROM on demand (of course, the 
APM Planner would need to support making this demand).

But I think it's more of an empirical question of which method results in fewer 
purposeless EEPROM writes.  Per-parameter writing eliminates writing all the 
other parameters when only one needs to be saved.  All-parameter writing 
eliminates writing parameters during changes to individual parameters when the 
other parameters don't need to be written.  I don't know which effect is 
bigger, but I feel like it should be the former.

Either way, APM Planner needs to be able to write PID parameters to EEPROM, 
right?

Original comment by bjpcalt...@gmail.com on 14 Mar 2011 at 11:58

[GoogleCodeExporter]

The current revision has been changed so that parameters are written to EEPROM 
when received.  It looks like writing parameters is taking a lot longer than I 
expected, so I am thinking to add back an option to not save them when received 
but only "save all" when requested.  If that option is used it is probably 
recommended to NOT do that in the air, but I need to see what the required time 
is....

Original comment by dewei...@gmail.com on 21 Mar 2011 at 3:27

[GoogleCodeExporter]

this is now fixed. setting are saved on upload.

Original comment by Meee...@gmail.com on 1 Apr 2011 at 12:23

• Changed state: Fixed