search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

Add fit validators #110

Closed hartytp closed 9 months ago

hartytp commented 12 months ago

In the previous version of the code, fit validation was done by the fitter based on a statistical test. That turned out to be overly restrictive - it's common to fit to simplified models, which don't capture all relevant physics, so the statistical tests will often fail even for a "good" fit. We should move validation out of the main fit and into separate validator classes.

hartytp commented 11 months ago

Initial framework added. The thing I'd like to see before closing this is to have the fitters provide a significance method which returns the fit significance (Chi2 for NormalFitter) then add a SignificanceValidator which compares the fit significance to a user-specified threshold value.