Allow parametrising the sinusoid in terms of min / max values

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics

Apache License 2.0

1 stars 0 forks source link

Allow parametrising the sinusoid in terms of min / max values #125

Closed hartytp closed 8 months ago

hartytp commented 11 months ago

Needs a test before merging.

@mbirtwell this implementation feels rather convoluted. Can you spot any tricks I've missed for making it simpler?

hartytp commented 11 months ago

Thinking about this more, I think that reparametrizing the model is probably not the right approach. It would be better to just add an additional set of parameters to the model which allow the offset / contrast to be specified by a combination of an offset/contrast and a min/max. Then just tell the user to pick a sensible combination to float.

@AUTProgram let's agree on parameter names and then I'll implement something.

hartytp commented 10 months ago

ping @AUTProgram

hartytp commented 8 months ago

Closing this in favor of a more generalized approach based on a new ReparametrizedModel container class