Closed hartytp closed 7 months ago
Yeah, that seems sensible as an approach to me.
This line:
args = {param.fixed_to for param in self.parameters.values() if param.fixed_to is not None}
Is constucting a set rather than the dictionary I think you need but that should be easy to fix.
aah, yeah, the set syntax always gets me. Okay, I'll add that then. It seems like a simple quality of life improvement.
Currently it's not particularly ergonomic to use a model "standalone" (not as a fit). e.g. one has to do something like
This feels unergonomic because:
_func
is maybe cleaner in that sense but is not public API and doesn't work for some modelsThe fact that we programmatically modify the model's parameters during
__init__
adds a few constraints to the problem. I'm not sure what the best option here, but maybe one is to do something likeThat allows one to modify the above model to something like
Any thoughts @mbirtwell ?
cc @m-malinowski (I know you had some issues with this a while back)