OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

calling `func` on RabiFlop does not work #170

Closed hartytp closed 8 months ago

hartytp commented 8 months ago

Since RabiFlop doesn't provide a func method, this falls through to Model. Model has x = np.atleast_2d(x) to deal with the various forms of input data we allow. However, RabiFlop's func takes a tuple as an input (breaking all the type annotations!).

Options:

  1. Don't allow this. Provide a func method which raises a NotImplementedError
  2. Do allow this. Provide a func method which calls _func itself. This is probably the right call and would be quick to do.