search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

Rename `SineMinMax` #172

Open AUTProgram opened 8 months ago

AUTProgram commented 8 months ago

This is a minor issue, but if we decide to change, might be worth doing now before the model is used more widely. The standard model for sinusoid fitting is called Sinusoid, but the reparameterised one is called SineMinMax. Any reason not to change this to SinusoidMinMax for consistency?

hartytp commented 8 months ago

I'd be open to that change if you want to submit a PR

AUTProgram commented 8 months ago

Ok, will do, but right now it's quite low priority on my list.