search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

refactor scale factors! #29

Closed hartytp closed 1 year ago

hartytp commented 1 year ago

Currently our scale funcs lambdas return a number that the parameter needs to be scaled by. This number is invariably the result of multiplying x_scale**n * y_scale**m. On reflection I think it might be better to just return n and m.

Context: on the experiment side of the code we want to be able to tell ndscan what units to use for the result channels. What I'd like to be able to do is to use information from the scale factors to relate the parameter units to the ndscan parameter/results used for the x and y values.

hartytp commented 1 year ago

On second thoughts let's not bother with this for now. We'll let users specify their own scale factors rather than trying to be too clever and getting bogged down in corner cases