search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

add non-normal fits #3

Closed hartytp closed 1 year ago

hartytp commented 2 years ago

Most relevant are PoissonianFit and BinomialFit. Probably the best path here is to add a MLEFit class which inherits from FitBase and handles the optimization, calculation of error contours etc. and gets statistics from a method which is NotImplementedError by default. NB NormalFit uses a y_err input. Binomial will need num_shots while Poisson distributions don't need anything beyond the x and y data.

hartytp commented 1 year ago

I'm going to close this for now as there is no immediate action. This is something which the library was designed to accommodate and should be possible without invasive changes to existing code; just needs doing when someone actually wants it!