Remove post_fit, calculate_derived_parameters takes x and y data as arguments.
Context: I have a use-case where I want to fit a sinusoid. The information I want to extract from the fit isn't directly the phase, but rather the peak closest to the centre of the x-axis dataset. After this PR, this can easily be achieved by overriding the model's calculate_derived_parameters method.
Generally, I think it makes more sense to have the post-fit analysis as part of the model than as part of the fitter so this also feels like good housekeeping.
Remove
post_fit,calculate_derived_parameterstakesxandydata as arguments.Context: I have a use-case where I want to fit a sinusoid. The information I want to extract from the fit isn't directly the phase, but rather the peak closest to the centre of the x-axis dataset. After this PR, this can easily be achieved by overriding the model's
calculate_derived_parametersmethod.Generally, I think it makes more sense to have the post-fit analysis as part of the model than as part of the fitter so this also feels like good housekeeping.