search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
0 stars 0 forks source link

Relax version bounds on scipy #48

Closed SquidDev closed 1 year ago

SquidDev commented 1 year ago

This removes the upper bound constraint on scipy, allowing us to use a more recent version in consumers of this library. I'm not wild about this - it means you don't get any protection about accidentally using features introduced in newer versions, but I don't think Poetry has a good solution to that.

CC @hartytp.

lochsh commented 1 year ago

I'm trying to remember the reason we had this, let me check. There was a reason that is hopefully now moot.

lochsh commented 1 year ago

https://github.com/OxIonics/ion-transport/pull/64/commits/cf8bd8c951c7acc303d3b6dafb49057ec93d9e7e

Could you try making the same change in ion-transport and running the tests? Basically some of ion-transport's other dependencies were using scipy features deprecated by 1.8 (and hadn't set their version constraints well).

I'm not wild about this - it means you don't get any protection about accidentally using features introduced in newer versions, but I don't think Poetry has a good solution to that.

I think poetry sees this as the library author's responsibilty, which is fair, but it can be inconvenient.

SquidDev commented 1 year ago

Have now resolved these issues in ion-transport (Oxionics/ion-transport#359), so think this should be okay now.