search

OxIonics / ionics_fits

Small python fitting library with an emphasis on Atomic Molecular and Optical Physics
Apache License 2.0
1 stars 0 forks source link

delegate rescaling parameters to the model #76

Closed hartytp closed 1 year ago

hartytp commented 1 year ago

Currently it's done in the fitter

https://github.com/OxIonics/ionics_fits/blob/77bac74dd78748832a4d8c8408f14cfb86d1cc43/ionics_fits/common.py#L527-L535

The disadvantage of that is that any parameters which aren't in the main parameters dictionary (e.g. the "fixed" parameters in a mapped model) are not correctly rescaled.