Open angerhang opened 1 year ago
Would it be better to introduce this enhancement in Actipy rather than BBA @angerhang @chanshing ?
Would it be better to introduce this enhancement in Actipy rather than BBA @angerhang @chanshing ?
Great idea Aiden. I am not familiar with the Actipy codebase so not sure how to do that exactly. It is also not clear that for new feature, which repository to contribute to because Actipy doesn't have many features that BBA has. Having to duplicate code in two repository just double the efforts for any new changes unfortunately :(
Maybe, let's get merged in BBA first, then create an issue on Actipy to add the light extraction is the a good first step?
Thanks, Hang. I'll put it on my todo list to implement it in actipy also.
All looks good. I'll think about how to rename ax3_light
and to distinguish it from light
. Thanks a lot Hang!
This feature is put on hold until the actipy backend migration finishes sometime next month.
Will revisit this end of January.
Test plan:
Output:
This PR might break some of the regression tests as it adds a new column to the extracted files but won't know until the tests are finished. Oh well, will have to regenerate the other reference data format but can anyone review this PR before I regenerate the reference extraction files? :D