OxalisCommunity / Oxalis-AS4

PEPPOL AS4 pMode plugin for Oxalis
32 stars 26 forks source link

The format of the "originalSender" and "finalRecipient" message property is not according to the Peppol specification #136

Closed phax closed 4 years ago

phax commented 4 years ago

Hi guys, the Oxalis version used in the Peppol Testbed creates the following XML:

   <ns2:Property name="originalSender">iso6523-actorid-upis::0088:tbcntrl00002</ns2:Property>
   <ns2:Property name="finalRecipient">iso6523-actorid-upis::9922:1122334455</ns2:Property>

Based on https://ec.europa.eu/cefdigital/wiki/display/CEFDIGITAL/eDelivery+AS4+-+1.14 chapter 4.2.6, the type attribute MUST be filled. Unfortunately the SBDH mapping of CEF and Peppol is slightly different.

Nevertheless my interpretation is, that the following XML is the correct one:

   <ns2:Property name="originalSender" type="iso6523-actorid-upis">0088:tbcntrl00002</ns2:Property>
   <ns2:Property name="finalRecipient" type="iso6523-actorid-upis">9922:1122334455</ns2:Property>

For backwards compatibility reasons on receiving you may check for the existence of the type attribute and build the identifier either as type + "::" + value or only as value.

aksamit commented 4 years ago

This might be a versioning issue, the OpenPeppol Test Bed not configured to run on the latest available version of Oxalis AS4.

Latest release of Oxalis AS4 seems to aim at fixing this issue.

But this is rather an issue to be handled by OpenPeppol Test Bed, than the Oxalis community.

phax commented 4 years ago

Yep, this is a duplicate of https://github.com/OxalisCommunity/Oxalis-AS4/issues/109 - closing this for now. Sorry for the confusion.