search

OxalisCommunity / oxalis

Oxalis - PEPPOL Access Point open source implementation - Core component
Other
130 stars 92 forks source link

SchemeId #136

Closed monze closed 10 years ago

monze commented 10 years ago

We are using Oxalis, the trunk version. I bug 127, I pointed out that some schemeIds was wrong, and this was fixed in commit 513.

But the commit introduced new errors. A example is with the GLN number, that now is defined as '88:xxxx...' instread of '0088:xxxx...'.

There now exist several SchemeId, that does not consist of 4 numbers.

    FR_SIRENE("FR:SIRENE", "2"),
    SE_ORGNR("SE:ORGNR", "7"),
    FR_SIRET("FR:SIRET", "9"),
    FI_OVT("FI:OVT", "37"),
    DU_S("DUNS", "60"),
    GL_("GLN", "88"),
    DK_P("DK:P", "96"),
    IT_FTI("IT:FTI", "97"),
    NL_KVK("NL:KVK", "106"),
    IT_SIA("IT:SIA", "135"),
    IT_SECETI("IT:SECETI", "142"),

This result in that the URL for the SMP server is now invalid. These two MD5 values is not equal:

Util.calculateMD5("88:xxxx...")
Util.calculateMD5("0088:xxxx...")

Jacob Mogensen mySupply ApS

teedjay commented 10 years ago

You are right, these were just copied "raw" from the PEPPOL docs - but looking at the ISO ICD specifications they should be 4 digits. A list with more details for each code can be found here : http://www.oid-info.com/doc/ICD-list.pdf

Fixed and pushed a new version.