Change request for SmpLookupManager

adammscisz commented 11 years ago

As far as I know current implementation of getServiceGroups() throws an exception if there are no document types participant can receive.

We would like to separate this scenario from one when ELMA is actually down.

Perfect solution would be:

return Collection.emptyList when the result set is empty
throw an exception when ELMA is down.

And also, SmpLookupException extends Throwable. Is there any particular reason it doesn't just extend Exception? We hardly ever catch Throwable which contain errors as well.

Thanks

adammscisz commented 11 years ago

I verified my expectations. When I do smpLookup on orgNo that's not registered I get: java.lang.IllegalStateException: Unable to connect to http://B-3ef88229f33cab598f9bad0185bad411.iso6523-actorid-upis.sml.peppolcentral.org/iso6523-actorid-upis%3A%3A9908:976098897 ; B-3ef88229f33cab598f9bad0185bad411.iso6523-actorid-upis.sml.peppolcentral.org ... Caused by: java.net.UnknownHostException: B-3ef88229f33cab598f9bad0185bad411.iso6523-actorid-upis.sml.peppolcentral.org

steinarcook commented 11 years ago

Jolly good, implemented in version 2.0.1

OxalisCommunity / oxalis

Change request for SmpLookupManager #23