search

OxalisCommunity / oxalis

Oxalis - PEPPOL Access Point open source implementation - Core component
Other
129 stars 91 forks source link

List of valid SchemeID's needs to be updated. #276

Closed teedjay closed 6 years ago

teedjay commented 7 years ago

Receiving documents on behalf of Belgian customers fail with : ERROR eu.peppol.inbound.server.AS2Servlet - Internal error: Value '9956' is not valid ICD.

Need to add Belgian Crossroad Bank of Enterprises to the list as BE:CBE / 9956

teedjay commented 7 years ago

Added missing code to 4.0.0-SNAPSHOT. Consider if this needs to be backported to 3.2.x as well?

monze commented 7 years ago

Just a comment on this issue

So far, the list was a match of the official PEPPOL SchemeId: Policy for use of Identifiers

Based on the current setup, we now have the following Scenario: Oxalis is transmitting the document with that SchemeId 9956 to another PEPPOL implementation. The other implementation do not know of the SchemaId value 9956, and the transmission will fail, because the SchemeId 9956 is an invalid value (according the the official list of valid SchemeIds).

So I strongly recommend to inform Peppol comminity to add the Belgian Crossroad Bank of Enterprises to the list of valid ids (update the definition). And based on their comment, add (if you can wait) the SchemeId if they accept.

Jacob Mogensen mySupply ApS Denmark

steinarcook commented 7 years ago

I think perhaps we should loosen up, and simply remove the check for valid ICD’s.

As consequence we simply treat it as a string, which is used for lookup in the SMP.

  1. jan. 2017 kl. 13.57 skrev monze notifications@github.com:

Just a comment on this issue

So far, the list was a match of the official PEPPOL SchemeId: Policy for use of Identifiers https://joinup.ec.europa.eu/svn/peppol/TransportInfrastructure/PEPPOL_Policy%20for%20use%20of%20identifiers-300.pdf Based on the current setup, we now have the following Scenario: Oxalis is transmitting the document with that SchemeId 9956 to another PEPPOL implementation. The other implementation do not know of the SchemaId value 9956, and the transmission will fail, because the SchemeId 9956 is an invalid value (according the the official list of valid SchemeIds).

So I strongly recommend to inform Peppol comminity to add the Belgian Crossroad Bank of Enterprises to the list of valid ids (update the definition). And based on their comment, add (if you can wait) the SchemeId if they accept.

Jacob Mogensen mySupply ApS Denmark

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/difi/oxalis/issues/276#issuecomment-270638124, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDq0fKVf6SpmyKBamtmdFwEnagMJu9Iks5rPOjEgaJpZM4LbgZx.

Steinar Overbeck Cook Tlf: +47 90 66 57 93

teedjay commented 7 years ago

This code and its usage was published on the official PEPPOL.EU website so I assume the Policy for Identifiers document should be revised.
http://www.peppol.eu/adoption/adoption/Belgium

I also see that other OpenPEPPOL implementation includes this code in recent revisions.

monze commented 7 years ago

teedjay: Haven't seen that. This means that is is just the documentation of the standard that is out-of-date.

steincook: The list is used to map the Endpoint type in the document (NO:ORG) to the SchemeId (9908), so it can just be removed. The mapning must be done at some place, either in Oxalis or in the system that use Oxalis. But if the list is as dynamic as it looks like, it should not be hardCode implementated in the source code. So moving it to a database or a list in OxalisHome, is not a bad idea.

Jacob Mogensen mySupply ApS Denmark

klakegg commented 6 years ago

As of Oxalis 4 are there no check of ICD when SBDH is provided.