OxalisCommunity / oxalis

Oxalis - PEPPOL Access Point open source implementation - Core component
Other
119 stars 89 forks source link

ERST: Tomcat relative oxalis home #625

Open nemhandel4erst opened 1 year ago

nemhandel4erst commented 1 year ago

Pull Request Description

Erhvervsstyrelsen (ERST) has implemented a Tomcat relative property home detector. It takes a property RELATIVE_OXALIS_HOME and detects that path relative to the Tomcat catalina.base property.

This is very useful for us because we place the oxalis home folder in the same location within the Tomcat folder. The absolute path to the Tomcat folder may vary across different environments or on developers' computers, making it inconsistent.

See change here: https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/master/oxalis-commons/src/main/java/dk/erst/oxalis/commons/filesystem/detector/RelativePropertyHomeDetector.java

Type of Pull Request

Type of Change

Pull Request Checklist:

dladlk commented 1 year ago

As you maybe noticed, 2 other changes in Oxalis I have already copied from ERST code base - described in the task https://github.com/OxalisCommunity/oxalis/issues/623 and https://github.com/OxalisCommunity/Oxalis-AS4/issues/206 with linked pull requests. This change I evaluated and found out, that it can reside in the nemhandel "extension" - so it is not critical to include it into the main code base. But I requested @aaron-kumar to review this change request.