@Oxalisviolacea
Overall, nice work here. You performed well enough on the assessment to merit a chance to make some changes that can promote you to technical ready. Please make the following updates by EOD Sunday:
[x] Update class names to use PascalCase convention. You will see class names follow that convention across different coding languages.
[x] For your methods that change boolean attributes, I'd like to see a little more specificity. For instance, changeCheese is not very descriptive... you could hypothetically use this method to remove the cheese from pasta, however. For now, I'd avoid methods that toggle, and pick ones that do something very intuitive. It is quite alright, and even encouraged, to have 1 method that assigns a boolean attribute to true and another to assign it to false
[x] I get what you're going for with lowercase_type, but it reads less like a method than your others. It could be argued lowercase can work like a verb, but I still think a verbier word would help that method name. That being said, this is a simple 'getter' method, and I'm more interested in your 'setter' methods that directly modify attributes.
Nice work overall! Please let me know if you have question about any feedback.
@Oxalisviolacea Overall, nice work here. You performed well enough on the assessment to merit a chance to make some changes that can promote you to
technical ready
. Please make the following updates by EOD Sunday:[x] Update class names to use PascalCase convention. You will see class names follow that convention across different coding languages.
[x] For your methods that change boolean attributes, I'd like to see a little more specificity. For instance,
changeCheese
is not very descriptive... you could hypothetically use this method to remove the cheese from pasta, however. For now, I'd avoid methods that toggle, and pick ones that do something very intuitive. It is quite alright, and even encouraged, to have 1 method that assigns a boolean attribute totrue
and another to assign it tofalse
[x] I get what you're going for with
lowercase_type
, but it reads less like a method than your others. It could be arguedlowercase
can work like a verb, but I still think a verbier word would help that method name. That being said, this is a simple 'getter' method, and I'm more interested in your 'setter' methods that directly modify attributes.Nice work overall! Please let me know if you have question about any feedback.