Closed EloyMartinez closed 1 week ago
[!CAUTION]
Review failed
The pull request is closed.
The changes introduce a new module named fork
across multiple files, enhancing the repository management functionality. A function to create a fork of an existing repository is implemented, along with necessary error handling and directory management. Additionally, a new struct ForkRequest
is introduced for handling HTTP requests related to forking. The routing and service layers are updated to accommodate these changes, including a new endpoint for handling fork operations. Overall, this update expands the capabilities of the repository management system.
File Path | Change Summary |
---|---|
src/lib/src/repositories.rs |
Added new module pub mod fork; and exported pub use fork::fork; . |
src/lib/src/repositories/fork.rs |
Introduced pub fn fork(original_repo_path: &Path, new_repo_path: &Path) -> Result<(), OxenError> and fn copy_dir_recursive(src: &Path, dst: &Path) -> Result<(), OxenError> . |
src/lib/src/test.rs |
Added variable let new_repo_dir = repo_dir.parent().unwrap().join("forked"); in run_empty_local_repo_test . |
src/lib/src/view.rs |
Added new module pub mod fork; . |
src/lib/src/view/fork.rs |
Introduced struct ForkRequest with fields: pub namespace: String , pub new_repo_name: Option<String> . |
src/server/src/controllers.rs |
Added new module pub mod fork; . |
src/server/src/controllers/fork.rs |
Added pub async fn fork(req: HttpRequest, body: web::Json<ForkRequest>) -> Result<HttpResponse, OxenHttpError> . |
src/server/src/routes.rs |
Added method services::fork() . |
src/server/src/services.rs |
Added new module pub mod fork; and public use declaration pub use fork::fork; . |
src/server/src/services/fork.rs |
Added function fn fork() -> Scope to define routing for /fork with POST requests. |
sequenceDiagram
participant Client
participant Server
participant Controller
participant Repository
Client->>Server: POST /fork
Server->>Controller: fork(req, body)
Controller->>Repository: fork(original_repo_path, new_repo_path)
Repository-->>Controller: Success/Failure
Controller-->>Server: HTTP Response (201 Created/Error)
Server-->>Client: Response
🐰 "In the burrow, a fork was made,
New paths to explore, no time to fade.
With hops and skips, we copy with care,
A repository fork, a joy to share!
So let us cheer for the code we write,
For every new feature brings pure delight!" 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@EloyMartinez my one thought is for large repos the recursive copy could take a long time - for the future we might want to kick off a background thread to do the copying and then have an api to get whether the fork had finished. I think we should ship this to let @Artforge start playing with it.
Also - is there any scenario in which we would want to be able to fork into the same namespace with a different name? That was my first intuition while testing locally - but not the use case from the hub.
I just realized the response doesn't actually return json either, just a 200, I'm going to return RepositoryCreationView
just so it is easier to see success
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
These changes enhance the repository management experience by providing a straightforward method for users to create forks while ensuring data integrity.