OxfordCodeReviewNet / forum

A central repository to coordinate code reviews between researchers at the University of Oxford
Creative Commons Attribution Share Alike 4.0 International
101 stars 8 forks source link

Reshaping array Python #14

Closed jasperhajonides closed 3 years ago

jasperhajonides commented 3 years ago

Brief project description

Hi, I'm Jasper a 4th year DPhil student in Experimental Psychology and have been using Python for a couple of years now.

I have a very short query about an (effectively) 15-line python function. This function reshapes an array based on an integer that is passed into the function.

The code

Language: Type:

Further details: The function is terribly inefficient, I would be interested to optimise the computational complexity and would be generally interested how to approach these type of array manipulations in a better way.

Code review format

I'd rather

inakleinbottle commented 3 years ago

I'd be happy to review your code

jasperhajonides commented 3 years ago

That would be great! When would suit you, I'm relatively flexible. Does Tuesday afternoon or Wendesday Morning work?

inakleinbottle commented 3 years ago

Tomorrow afternoon is probably fine, around 2pm? Wednesday is not good for me.

jasperhajonides commented 3 years ago

Sure 2pm works for me, I can send you a zoom link tomorrow?

inakleinbottle commented 3 years ago

yes that would be fine, or we can do teams if you prefer.

jasperhajonides commented 3 years ago

Maybe thats easier, if you can drop me a message around 2pm? Thanks! Jasper Hajonides van der Meulen