search

OxfordIonTrapGroup / oitg

Python package of helper routines (result loading, fitting, etc) for the Oxford Ion-Trap Group (OITG).
https://oxfordiontrapgroup.github.io/oitg/
13 stars 9 forks source link

oitg.fitting.sinusoid unit tests fail #17

Closed dnadlinger closed 5 years ago

dnadlinger commented 5 years ago

As per the title; specifically test_delayed_split_data_with_t_dead fails deterministically: https://circleci.com/gh/OxfordIonTrapGroup/oitg/84

dnadlinger commented 5 years ago

(This wasn't caught before because the fitting tests weren't actually executed on the CI system.)

pathfinder49 commented 5 years ago

Hm, it worked when I ran them on my machine... I'll look into it.

dnadlinger commented 5 years ago

Fails on my local macOS box too (SciPy 1.2.1) – can let you have a look tomorrow if unreproducible on your end. (You can also SSH into CircleCI's machines, I believe.)

pathfinder49 commented 5 years ago

Did they fail before the latest sinusoid commit? I coult imagine that violating the "fourier" limit might mess lombscargle around.

pathfinder49 commented 5 years ago

Turns out the test is working fine. Relaxing the "Fourier" limit makes the fitting fail the test.