Fitting with no parameter bounds raises exception

OxfordIonTrapGroup / oitg

Python package of helper routines (result loading, fitting, etc) for the Oxford Ion-Trap Group (OITG).

https://oxfordiontrapgroup.github.io/oitg/

13 stars 9 forks source link

Closed pathfinder49 closed 4 years ago

pathfinder49 commented 5 years ago

Fits with no bounds call scipy leastsq instead of scipy least_squares. See curve_fit documentation

kwargs

Keyword arguments passed to leastsq for method='lm' or least_squares otherwise.

this case raises FitError: leastsq() got an unexpected keyword argument 'x_scale'

Proposed solution: set the method to always use scipy least_squares

pathfinder49 commented 5 years ago

Sorry this should be in this PR