search

OxfordIonTrapGroup / oitg

Python package of helper routines (result loading, fitting, etc) for the Oxford Ion-Trap Group (OITG).
https://oxfordiontrapgroup.github.io/oitg/
13 stars 9 forks source link

Error for Loading results #37

Closed sbrudney closed 3 years ago

sbrudney commented 3 years ago

https://github.com/OxfordIonTrapGroup/oitg/blob/768b2d5be8cf189b192d025877518a227171177f/oitg/rid_index.py#L33

Is this line supposed to be "!=" or "=" instead of ":="? Changing to "!=" allows me to load results, while leaving it as is gives an error.

dnadlinger commented 3 years ago

This is the "walrus operator", introduced in Python 3.8.

dnadlinger commented 3 years ago

(https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions)

sbrudney commented 3 years ago

I tried it with python 3.8 and it works fine. Thank you!