Open hartytp opened 2 years ago
Sounds good to me. Some thoughts:
I imagine you could find the sign more robustly using y(x_min), y(x_max), max(y) and min(y).
Can you sketch out what you had in mind? I agree there should be a good solution here but don't quite see it.
Maybe keep the two graidients as derived parameters for better back compatibility
:+1:
The heuristics for v_function are currently not great.
Thoughts
x0
asmean(x)
only works if the v function is decently well centred. I've found this to be pretty fragiley
doesn't work that well in my experienceI'd be interested in input on better ideas if people have them?